Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backdrop, badge, and table tsx, tests, stories, and default … #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dbhagen
Copy link

@dbhagen dbhagen commented Dec 30, 2020

I don't know if this will help us get a release that supports TailwindCSS v2.0, but these look to be the needed changes to support it.

updated to Tailwindcss2

Updated to tailwindcss@^2.0, updating minor class name changes to support new renames. Tests had to
be adjusted to support the new classes as well. Added a couple of Stories to Storybook to see how
things looked.

BREAKING CHANGE: Requires TailwindCSS@^2.0

…theme): updated to Tailwindcss2

Updated to tailwindcss@^2.0, updating minor class name changes to support new renames. Tests had to
be adjusted to support the new classes as well. Added a couple of Stories to Storybook to see how
things looked.

BREAKING CHANGE: Requires TailwindCSS@^2.0
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #27 (3659c5f) into master (258f4ae) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          495       495           
  Branches        77        77           
=========================================
  Hits           495       495           
Flag Coverage Δ
unittest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Table.tsx 100.00% <ø> (ø)
src/themes/default.ts 100.00% <ø> (ø)
src/Backdrop.tsx 100.00% <100.00%> (ø)
src/Badge.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 258f4ae...3659c5f. Read the comment docs.

Missed the dependancy on @tailwindcss/forms in the config.js file. Changed it to @tailwindcss/forms
from @tailwindcss/custom-forms.
@Priultimus
Copy link

Is this looking to be merged anytime soon? Tailwind 2 support would be fabulous.

@estevanmaito
Copy link
Owner

@Priultimus yes. This is my TODO list for 1.0. I'm taking a deeper look into this PR rn, and should be able to merge it with some additions to a beta 1.0 version (with just the Tailwind upgrade for now, which is the bigger braking change). I want to get it done soon, but I can't provide a time frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants