Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-H2 support #13

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Aug 11, 2023

Add esp32h2 support to the Direct Boot example.

To build an example:

  • For esp32c3: cmake -B build -D target=esp32c3 -G Ninja .
  • For esp32h2: cmake -B build -D target=esp32h3 -G Ninja .
  • cmake --build build

common/start.S Outdated Show resolved Hide resolved
examples/blink/CMakeLists.txt Outdated Show resolved Hide resolved
examples/blink/CMakeLists.txt Outdated Show resolved Hide resolved
@roma-jam roma-jam marked this pull request as ready for review August 14, 2023 21:38
@roma-jam roma-jam marked this pull request as draft August 14, 2023 21:40
@roma-jam
Copy link
Collaborator Author

roma-jam commented Aug 14, 2023

Ah no, too early to move it from Draft. There are still problem with hello_world example.
For some reason, the cpu restarting because of the RTC WDT Reset.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
configure.cmake Outdated Show resolved Hide resolved
examples/blink/README.md Outdated Show resolved Hide resolved
@roma-jam roma-jam marked this pull request as ready for review September 18, 2023 19:46
@roma-jam
Copy link
Collaborator Author

Now everything works.
LED blinks, Hello, world! appears on the UART0 (TX pin) of the H2 board.

I have not squashed the commits (for easier review process). If I need to squash them before merge, please tell me and I will do that without any problem.
Thanks.

@roma-jam roma-jam requested a review from igrr September 20, 2023 10:54
Copy link
Member

@igrr igrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @roma-jam, I left just a couple of nitpicky comments.

README.md Outdated Show resolved Hide resolved
img/esp32h2-directboot.svg Outdated Show resolved Hide resolved
ld/esp32h2/common.ld Outdated Show resolved Hide resolved
@roma-jam
Copy link
Collaborator Author

@igrr Thank you so much for the review! 🙏

I have fixed all the nitpicks.
If you have anything that in your opinion I can make better feel free to share.

@igrr
Copy link
Member

igrr commented Sep 21, 2023

@roma-jam
Copy link
Collaborator Author

@igrr No problem, I think that I can fix that.
But it seems that I am not able to trigger Actions, so I have changed the build.yml file and hope that it will work without any problem. Also, I have checked YML syntax with some online verification tool but I have not installed anything to verify it locally.

Probably, it is better do install any tool to be able to run build actions locally, isn't it?

@igrr
Copy link
Member

igrr commented Oct 3, 2023

@roma-jam Looks good to me to be merged, could you please clean up the history?

@roma-jam
Copy link
Collaborator Author

roma-jam commented Oct 3, 2023

@roma-jam Looks good to me to be merged, could you please clean up the history?

@igrr ,
Sure, no problem!

@roma-jam
Copy link
Collaborator Author

roma-jam commented Nov 3, 2023

@igrr
Thanks for giving me the chance to help in such an interesting project.
Is there anything else you want to check/verify? Or I can merge pull request?

Thanks 🙏

@igrr
Copy link
Member

igrr commented Nov 3, 2023

Yes, please go ahead and merge!

@igrr igrr closed this Nov 3, 2023
@igrr igrr reopened this Nov 3, 2023
@roma-jam roma-jam merged commit bac08da into espressif:main Nov 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants