-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32-H2 support #13
ESP32-H2 support #13
Conversation
Ah no, too early to move it from Draft. There are still problem with hello_world example. |
Now everything works. I have not squashed the commits (for easier review process). If I need to squash them before merge, please tell me and I will do that without any problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @roma-jam, I left just a couple of nitpicky comments.
@igrr Thank you so much for the review! 🙏 I have fixed all the nitpicks. |
@roma-jam I forgot one thing in the previous review, please also take a look and update the CI workflow: |
0d768c9
to
eb2450e
Compare
@igrr No problem, I think that I can fix that. Probably, it is better do install any tool to be able to run build actions locally, isn't it? |
@roma-jam Looks good to me to be merged, could you please clean up the history? |
eb2450e
to
49dc3d2
Compare
@igrr Thanks 🙏 |
Yes, please go ahead and merge! |
Add esp32h2 support to the Direct Boot example.
To build an example:
cmake -B build -D target=esp32c3 -G Ninja .
cmake -B build -D target=esp32h3 -G Ninja .
cmake --build build