From 7f7b0ae9a79a6498642d64d7957d28ba23c0c660 Mon Sep 17 00:00:00 2001 From: valeriojr <41243914+valeriojr@users.noreply.github.com> Date: Mon, 13 Jun 2022 13:37:00 -0300 Subject: [PATCH 1/3] =?UTF-8?q?=E2=9C=8Ftypo=20in=20comment?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit blightness -> brightness --- components/modules/camera/who_camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/modules/camera/who_camera.c b/components/modules/camera/who_camera.c index 778ded13..cfcfc215 100644 --- a/components/modules/camera/who_camera.c +++ b/components/modules/camera/who_camera.c @@ -78,7 +78,7 @@ void register_camera(const pixformat_t pixel_fromat, //initial sensors are flipped vertically and colors are a bit saturated if (s->id.PID == OV3660_PID) { - s->set_brightness(s, 1); //up the blightness just a bit + s->set_brightness(s, 1); //up the brightness just a bit s->set_saturation(s, -2); //lower the saturation } From f65158536626212416173cd57b7282636e3d5a7f Mon Sep 17 00:00:00 2001 From: valeriojr <41243914+valeriojr@users.noreply.github.com> Date: Mon, 13 Jun 2022 15:14:29 -0300 Subject: [PATCH 2/3] =?UTF-8?q?=E2=9C=8Ftypo=20in=20comment?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "firstly declair it" -> "firstly declare it" --- components/modules/camera/who_camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/modules/camera/who_camera.c b/components/modules/camera/who_camera.c index 778ded13..11a2aec4 100644 --- a/components/modules/camera/who_camera.c +++ b/components/modules/camera/who_camera.c @@ -26,7 +26,7 @@ void register_camera(const pixformat_t pixel_fromat, #if CONFIG_CAMERA_MODULE_ESP_EYE || CONFIG_CAMERA_MODULE_ESP32_CAM_BOARD /* IO13, IO14 is designed for JTAG by default, * to use it as generalized input, - * firstly declair it as pullup input */ + * firstly declare it as pullup input */ gpio_config_t conf; conf.mode = GPIO_MODE_INPUT; conf.pull_up_en = GPIO_PULLUP_ENABLE; From 7b780e68130ddbc27c95067dbe255524ae60f1b5 Mon Sep 17 00:00:00 2001 From: Nikolaus Spence <125481816+nikolausspence@users.noreply.github.com> Date: Mon, 27 Mar 2023 11:39:57 -0500 Subject: [PATCH 3/3] increase stack size of who_camera task program was crashing with "1 * 1024" stack size, it was changed to "2 * 1024" but would still crash during some conditions. Changed to "3 * 1024" and the task does not experience a stack overflow under any circumstances. --- components/modules/camera/who_camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/modules/camera/who_camera.c b/components/modules/camera/who_camera.c index 778ded13..707d11a3 100644 --- a/components/modules/camera/who_camera.c +++ b/components/modules/camera/who_camera.c @@ -83,5 +83,5 @@ void register_camera(const pixformat_t pixel_fromat, } xQueueFrameO = frame_o; - xTaskCreatePinnedToCore(task_process_handler, TAG, 2 * 1024, NULL, 5, NULL, 1); + xTaskCreatePinnedToCore(task_process_handler, TAG, 3 * 1024, NULL, 5, NULL, 1); }