Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-adf-libs includes a hidden copy of libopus #20

Open
hossbeast opened this issue Aug 30, 2022 · 1 comment
Open

esp-adf-libs includes a hidden copy of libopus #20

hossbeast opened this issue Aug 30, 2022 · 1 comment

Comments

@hossbeast
Copy link

I've noticed that esp-adf-libs includes a bundled copy of libopus, from https://github.com/xiph/opus. I described my findings here - XasWorks/esp-libopus#3

My request is that esp-adf-libs 1) make it clear that libopus is included with esp-adf-libs, including precise version information, and 2) vend the libopus header files from whatever version it was built from.

Opus is great, and folks have a need for it to be built for esp32. Make it obvious that it's there and make it easy to use - that can only help the users of esp-adf-libs.

@jason-mao
Copy link
Contributor

@hossbeast The copyrights notice on https://docs.espressif.com/projects/esp-adf/en/latest/COPYRIGHT.html. The version of opus is v1.2.1, which will be update on esp-adf-libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants