Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another Wire requestFrom function signature #5764

Closed

Conversation

torntrousers
Copy link
Contributor

Arduino HardwareI2C defines a requestFrom function

    virtual size_t requestFrom(uint8_t address, size_t len, bool stopBit) = 0;

whereas the ESP32 Wire doesn't include any requestFrom using size_t types, so this can cause a compile error, eg when using the Arduino ATECC608 library with an ESP32, see arduino-libraries/ArduinoECCX08#25

@me-no-dev
Copy link
Member

seems you did not start from clean Master? There are conflicts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants