ISSUE-443: Better Date Range Facets #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor. Better JS driven, better PHP, safer, more options. Still WIP, need to override the queries now and process the Sol JSON API Facet & stats
Allows IABookeader to match a sequence (from Solr) against the UUID loaded in the IIIF Manifest. Basically allowing multiple PDFs to work out Requires : - testing (more) - Canvase IDs that end with /file_uuid/canvas/p1 or video1 or anything that ends with a number for the actual page @alliomeria yeah ... that
works like this
sbf_file_content("uuid_of_the_node", "uuid_of_the_file", "thename.jsonld");
Will return the content of a file if found/matches one of the mimetypes defined as valid for our metadata displays, now defined as constants at
CONST ALLOWED_MIMETYPES = [
'text/html' => 'HTML',
'application/json' => 'JSON',
'application/ld+json' => 'JSON-LD',
'application/xml' => 'XML',
'text/text' => 'TEXT',
'text/turtle' => 'RDF/TURTLE',
'text/csv' => 'CSV',
];
an error message in case of exception or an empty string if the file does not exist, the user has no permission, is not of an allowed type, etc (avoiding as much as possible errors)
@alliomeria i am truly smartz! (and modest too!)
Basically keep doing that/delaying the event until (if ever) we have an event listener. Also attach the event listener only to the Body. We need it only once. Not more.
Also updates them. Probably missing some "side" effects of this
…nder errors Next step is to make it "elegant"
Can be better. But i feel like this already very very nice @alliomeria
Many render arrays can be nested of sub-sub things. One does never know. So we only bail out when a Key is numeric and the value is scalar.
.. just Catch any exception. We can only catch "logic Exceptions". This is some advanced stuff @alliomeria . So so hard
this header... never had an issue before 2024
Because IOS/Safari as dumb (very) see #485 also do some indentation...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #443
Complete Refactor. Better JS driven, better PHP, safer, more options. Still WIP, need to override the queries now and process the Sol JSON API Facet & stats
Includes #480 and #483