Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sebastian Good <[email protected]>
  • Loading branch information
aladdin-add and scagood authored Jan 4, 2024
1 parent 6f2b3bd commit 7b96327
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ npm install --save-dev eslint eslint-plugin-n

| Version | Supported Node.js | Supported ESLint Version |
|---------|-------------------|---------------------------|
| 17.x | `Node.js:^18.18.0 \|\| ^20.9.0 \|\| >=21.1.0` | `ESLint>=8.23.0` |
| 16.x | `Node.js>=16.0.0` | `ESLint>=7.0.0` |
| 15.x | `Node.js>=12.22.0` | `ESLint>=7.0.0` |
| 17.x | `^18.18.0 \|\| ^20.9.0 \|\| >=21.1.0` | `>=8.23.0` |
| 16.x | `>=16.0.0` | `>=7.0.0` |
| 15.x | `>=12.22.0` | `>=7.0.0` |

**Note:** It recommends a use of [the "engines" field of package.json](https://docs.npmjs.com/files/package.json#engines). The "engines" field is used by `n/no-unsupported-features/*` rules.

Expand Down
4 changes: 2 additions & 2 deletions tests/eslint-rule-tester.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
*/
"use strict"
const eslintVersion = require("eslint/package.json").version
const RuleTester = require("eslint").RuleTester
const unofficialApis = require("eslint/use-at-your-own-risk")
const { RuleTester } = require("eslint")
const { FlatRuleTester } = require("eslint/use-at-your-own-risk")

Check failure on line 8 in tests/eslint-rule-tester.js

View workflow job for this annotation

GitHub Actions / Lint

'FlatRuleTester' is assigned a value but never used
const globals = require("globals")

// greater than or equal to ESLint v9
Expand Down

0 comments on commit 7b96327

Please sign in to comment.