From 8612dec72b4f4b536872b42b8b27c1a4eecc6748 Mon Sep 17 00:00:00 2001 From: Mikhail Uvarov Date: Thu, 12 Dec 2024 12:57:29 +0100 Subject: [PATCH 1/2] Reorder examples (because 'The same command as above' does not make sense now) --- tools/test-runner.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/test-runner.sh b/tools/test-runner.sh index 46730446f2..800634126c 100755 --- a/tools/test-runner.sh +++ b/tools/test-runner.sh @@ -116,12 +116,12 @@ Script examples: Sets dev-nodes and test-hosts to empty lists Reruns mam_SUITE -./tools/test-runner.sh --skip-small-tests --skip-start-nodes --skip-validate-nodes -- connect - Continues test execution even if MongooseIM is not running on all nodes - ./tools/test-runner.sh --rerun-big-tests -- mam The same command as above +./tools/test-runner.sh --skip-small-tests --skip-start-nodes --skip-validate-nodes -- connect + Continues test execution even if MongooseIM is not running on all nodes + ./tools/test-runner.sh --help --examples --colors | more Display help using "more" command END From 6764754c78a78c7d579eb143c5e2da7ec8574bb6 Mon Sep 17 00:00:00 2001 From: Mikhail Uvarov Date: Thu, 12 Dec 2024 12:58:11 +0100 Subject: [PATCH 2/2] Parse TEST_HOSTS='' correctly It got parsed into [''] --- test/common/distributed_helper.erl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/common/distributed_helper.erl b/test/common/distributed_helper.erl index 9ace65deb7..3edcd4ab13 100644 --- a/test/common/distributed_helper.erl +++ b/test/common/distributed_helper.erl @@ -231,7 +231,7 @@ get_node_keys() -> [NodeKey || {NodeKey, _Opts} <- ct:get_config(hosts)]; EnvValue -> %% EnvValue examples are "mim" or "mim mim2" BinHosts = binary:split(iolist_to_binary(EnvValue), <<" ">>, [global]), - [binary_to_atom(Node, utf8) || Node <- BinHosts] + [binary_to_atom(Node, utf8) || Node <- BinHosts, Node =/= <<>>] end. validate_node(NodeKey) ->