Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More standards-compliant code formats? #125

Open
jooh opened this issue Feb 19, 2019 · 2 comments
Open

More standards-compliant code formats? #125

jooh opened this issue Feb 19, 2019 · 2 comments

Comments

@jooh
Copy link

jooh commented Feb 19, 2019

I just started working on the code, and it's a little tricky to get used to some of the non-standard conventions, especially the super-deep indentation. Would it be worth running the whole repo through black to get something more PEP-8 compliant?

Similarly, the windows carriage returns are kind of annoying (top tip - set git config --local core.whitespace cr-at-eol to stop them showing up in git diff). Not sure if black will convert file endings anyway, but if not, a pass through dos2unix wouldn't hurt either...

@esdalmaijer
Copy link
Owner

Yeah, we should probably get on 4-space indentation, and a few more PEP8 compliances.

Thanks for the carriage return tips! Most of this stuff is written on a mixture of operating systems, and I don't always pay attention to these things.

@jooh
Copy link
Author

jooh commented Feb 26, 2019

If you're up for it, I can just run the repo through black and submit a PR. That should get you fairly strict PEP8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants