Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better decompiler output #33

Open
RyanHope opened this issue May 2, 2024 · 5 comments
Open

Better decompiler output #33

RyanHope opened this issue May 2, 2024 · 5 comments

Comments

@RyanHope
Copy link

RyanHope commented May 2, 2024

Is there anyway to improve the RH850 decompiled output a little bit... below is an example of the output from your extension:

image

And this is the upstream v850 output:

image

@RyanHope
Copy link
Author

RyanHope commented May 7, 2024

Here is another spot, idk if this should be its own issue or not.

image

@RyanHope
Copy link
Author

RyanHope commented May 8, 2024

I am not sure what is going on here...
image

Here is an example use of that function:
image

@esaulenka
Copy link
Owner

I am not sure what is going on here...

0x1'0000'0000 - 0x2F'FCB0 = 0xFFD0'0350
Probably 0xFFD0xxxx belongs to the CAN peripheral (will be better to check user manual for your chip).
Try to add this memory area and reanalyze this (and similar) function.

@esaulenka
Copy link
Owner

Is there anyway to improve the RH850 decompiled

I dont understand what's going here. Probably you have declared a bit different types (at least, if you use default colors, the first image has volatile RAM area, that can significantly change decompiler output).

@RyanHope
Copy link
Author

RyanHope commented May 8, 2024

I am not sure what is going on here...

0x1'0000'0000 - 0x2F'FCB0 = 0xFFD0'0350 Probably 0xFFD0xxxx belongs to the CAN peripheral (will be better to check user manual for your chip). Try to add this memory area and reanalyze this (and similar) function.

you were right, I didnt have that memory segment defined, thought I did previously, must have deleted it by mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants