Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Añadir parte del EsDom API #9
base: develop
Are you sure you want to change the base?
Añadir parte del EsDom API #9
Changes from 18 commits
c9871f1
059d932
dd9d530
17e8d2d
4123e43
17ba72d
bf2da0d
b24ed2d
ac72d9a
bdc5860
0a7ff97
b9a220b
e3913e1
47341ed
11d2c6f
7f96e0d
1bda6df
f60f5aa
c7f2644
16b6683
b379625
0c4ff03
ead21f9
02e8f78
8216fbf
928fbd3
88d5a56
d5b357a
30b3fce
b2186ca
ae5c4c3
59f7e68
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Corrección de traducción: 'createNSResolver' debería ser 'crearResolverNS'
El método 'createNSResolver' se traduce más apropiadamente como 'crearResolverNS', ya que 'resolver' es 'resolver' en este contexto. 'Solucionar' se refiere más a 'solve' que a 'resolve'.
Aplicar el siguiente cambio:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Unificar terminología: Reemplazar 'Secundario' por 'Hijo'
El término "hijo" es la traducción más comúnmente aceptada para "child" en programación y DOM. Se recomienda reemplazar "Secundario" por "Hijo" para mejorar la claridad y alinearse con las convenciones estándar.
Aplicar el siguiente cambio:
Also applies to: 87-87, 96-96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crea un commit para esto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enzonotario, entiendo su solicitud, pero no puedo crear un commit directamente en el repositorio. Por favor, aplique el cambio sugerido en su entorno local y realice el commit correspondiente.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Unificar terminología: Reemplazar 'Secundario' por 'Hijo'
El término "hijo" es más apropiado para referirse a 'child' en el contexto del DOM.
Aplicar los siguientes cambios:
Also applies to: 84-85, 93-93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Corrección de traducción: Reemplazar 'Activo/Activa' por 'Habilitado/Habilitada'
La palabra "Enabled" se traduce más apropiadamente como "Habilitado" o "Habilitada" en lugar de "Activo/Activa". Para mayor precisión en la traducción de las propiedades, se sugiere actualizar los nombres.
Aplicar el siguiente cambio:
Also applies to: 112-112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crea un commit para esto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enzonotario, lo siento, pero no tengo la capacidad de crear commits en el repositorio. Sin embargo, puedes aplicar los cambios sugeridos para corregir las traducciones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Corrección de traducción: Reemplazar 'Activo/Activa' por 'Habilitado/Habilitada'
Para mayor precisión, se sugiere usar 'Habilitado' en lugar de 'Activo'.
Aplicar los siguientes cambios:
Also applies to: 109-109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crea un commit para esto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enzonotario, entiendo tu solicitud, pero como asistente, no puedo crear commits directamente en el repositorio. Por favor, aplica los cambios sugeridos manualmente en tu PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Sugerencia: Revisar la traducción de 're' a 'xr'
La clave
"re"
se está traduciendo a"xr"
. Puede que"re"
no sea la representación más clara en español para "XR" (realidad extendida). Considera utilizar"xr"
directamente o una traducción más descriptiva como"realidadExtendida"
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Mantener consistencia en el uso de comillas
En las líneas 52 a 54, las claves están entre comillas simples (
'javaHabilitado'
,'obtenerNotificaciones'
), mientras que en el resto del archivo se utilizan comillas dobles. Para mantener la consistencia y legibilidad, sería recomendable unificar el estilo de comillas en todo el mapa.