-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklists (LINK TO POH IN HERE) #3
Comments
bonanza-g36-POH-compressed.pdf I'm making a start on the Pre-flight checklist on pages 162-167 |
Hi @TheFrett |
Hey, I haven't thought about this yet. Someone mentioned it on the forum so I thought lets raise it as an issue to work on later. If you want to pick up this task please go ahead! The POH is a good source. maybe indicate which elements are not working in the sim on the checklist. Question: do you include interactive elements as well (highlighting switches, moving view etc?) |
@50North4West Thanks for starting work on the checklists. Since no other a/c in the sim lists their emergency procedures, I don't see a reason to with the G36. |
I'm not great on the flight dynamics modelling so certainly somewhere I can help. I think we have come to as far as we can with the warnings etc. I've managed so far to use the interactive elements for the pre-flight part. It seems fairly intuitive to make them although their (Asobo's) code is spread out over a number of files which takes a while to find how they do it. Thoughts on including the non-modeled elements such as Landing Gear Emergency Handcrank ??? Once I finish pre-flight I'll send a pull request. |
It's up to you if you ask me... Personally I'm okay with keeping non-modeled items out, accessibility is still important. I can imagine newcomers being frustrated trying to go through a checklist and coming upon all this stuff they can't find or interact with. |
I had the same thoughts. I'll leave out non-modelled functions but leave commented code spaces in case we go mad and add some bits and bobs |
HI All, Sorry for lack of updates so far; I'm moving house at the moment and trying to snatch time in between packing boxes. Should be in a position to do more effective work from Monday next week. |
No worries! It's not a job. I work on it when I feel like it to keep it fun. Your work is very much appreciated, I will test the checklist tomorrow! |
Although always a good way to get out of packing and loading the car ;-) |
@50North4West How much is there to do before v0.5 release do you think? |
Not much, feedback so far has been good. I've got to remove a few camera changes and I cant seem to get the copilot to recognise the bus2 voltage but other than that I think we're ready with regard an initial checklist release. How have you found them? I've pretty much finished sections 1 & 2 of the documentation, and checked we can leave the folder in the mod structure without registering it on the json. Do you want to include that as a start? I'll have a crack after work tonight to sort those last bits, I think @jonas? mentioned a few wording changes... |
Hi Matt, Since I've added some new working switches, maybe we can include them in the checklist?
Actually that may be the only one that should be in there (bit of an anticlimax here) |
Will do :-) Do you know what the switch is called?? We get it to highlight with Once we have the switch ID and I wonder if we can get a simvar or xmlvar to check whether the lights are on or not.
|
Same as NODE_ID, see above. |
Thanks - have tried using SAFETY_Push_Annunciator, G36_Annun_Test, and ANNUNCIATOR_TEST as the instrument Id but none of them highlight the switch??? Might need to check which branch you're working on... |
That's weird. Can't think of another name. The NODE_ID and instrument ID's correspond for all others... Which branch I work on shouldn't matter. I did not change any definitions in the model names. G36_Annun_Test is the name of the custom template (which is in CustomTemplates.xml) and ANNUNCIATOR_TEST is an arbitrary name for the component in the interior.xml. |
Thanks will carry on trying :-) |
Can you try for: ELECTRICAl_Switch_AC These are also former (Inop.) items... |
Will do, just rebooting the sim :-) |
None of those have the blue highlight when putting them into the |
Just did some digging through the MSFS code and found the issue. We need to add a PART_ID to the templates in \ModelBehaviorDefs\G36X\Subtemplates\G36_Subtemplates.xml E.g.
I can then put |
Ah nice, great find! Learned something again about the modelbehavior XML. However, try to add it to the appropriate lines in Interior_Model.xml, like so:
This should be possible since the usedtemplates inherit from the template that calls them. In other words, when the PART_ID is given as argument in the above lines, it will pass the PART_ID to all underlying used templates (including the G36_pushbutton_xml, which is called in G36_Annun_Test). Although this subtemplate is only used by the annunciator test now, I'd like to stick to the format and conventions that Asobo uses. For example: if we have more buttons making use of G36_pushbutton_xml, we have to give the unique PART_ID explicitly like in the above example, so setting a default for this does not make sense as the purpose of the subtemplate is to be applicable to whatever interactive element is passed on to it. As for the name: the PART_ID (if used) is usually the same as NODE_ID and ANIM_NAME from what I've seen so far. Could you test if this works? |
I must say that I'm not very consistent either at the moment. For example with regards the the annunciator example I pass NODE_ID and ANIM_NAME as argument in the Interior_Model.xml file and reference them in CustomTemplates as #NODE_ID# and #ANIM_NAME# respectively (which are then passed on the the used subtemplate if applicable), whereas for the landing gear and the flaps I explicitly give the NODE_ID (Not ANIM_NAME because they are only lights) in the CustomTemplates.xml file itself... Since each custom template is unique to the switch/function they reference, I should probably move the NODE_ID and ANIM_NAME there (as well as PART_ID if we start adding those), such that I only have to call the templates with no arguments in the interior model file. |
Hey @TheFrett, yep that works :-) I added it to Bonanza_g36_interior.xml as you mentioned in the snippet and can confirm all works as you thought. I think my orignial pull request has updated with the code??? |
Complete checklist XML's
The text was updated successfully, but these errors were encountered: