Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support rtl #35

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

support rtl #35

wants to merge 5 commits into from
+120 −74

Conversation

ekasetiawans
Copy link

added RTL support, this will be fix for #29

@eric-taix
Copy link
Owner

Thanks for your contribution. I had a quick look this morning on my phone. There's a lot of unrelated changes probably due to different line length configuration which makes difficult to see exactly what you have changed.
But I'll check it this night.

@eric-taix
Copy link
Owner

Can you update the version number of this package to 1.4.0 please?

@ekasetiawans
Copy link
Author

Thanks for your contribution. I had a quick look this morning on my phone. There's a lot of unrelated changes probably due to different line length configuration which makes difficult to see exactly what you have changed.
But I'll check it this night.

@eric-taix actually I just change lib/src/fluid_nav_bar.dart

@ekasetiawans
Copy link
Author

@eric-taix have you checked this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekasetiawans @eric-taix