Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose NiPoPoW relevant implementations as a dependency #1813

Closed
MrStahlfelge opened this issue Aug 20, 2022 · 3 comments
Closed

Expose NiPoPoW relevant implementations as a dependency #1813

MrStahlfelge opened this issue Aug 20, 2022 · 3 comments

Comments

@MrStahlfelge
Copy link
Member

From ergoplatform/ergo-appkit#187 this is needed to have exposed to Appkit for client applications to adopt Nipopows:

  • move NipopowProof, NipopowVerifier, and all dependent types from node code into a lib (ergo-wallet?);
  • expose NipopowProof, NipopowVerifier, MerkleProof with mentioned above properties/methods in appkit public API.

Actually, I'm pretty sure that the above NiPoPoW-related types would better be in a dedicated ergo-nipopow lib since they are not directly related to wallet features. However, the bigger challenge will be the dependent more low-level types like Header, etc. Seems like they should be moved to their own separate lib (ergo-core/ergo-chain-types?).

@greenhat
Copy link
Member

greenhat commented Mar 2, 2023

Hey! I missed this issue and made a new one #1965 for the same task. Do you mind if I close this one?

@MrStahlfelge
Copy link
Member Author

Feel free to close this one or the other one, depending on which one has a better description :)

@greenhat greenhat closed this as completed Mar 2, 2023
@greenhat
Copy link
Member

greenhat commented Mar 2, 2023

Closed in favor of #1965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants