Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed torrent links with spaces aren't handled correctly #1213

Open
SquirrelKiev opened this issue Oct 15, 2024 · 2 comments
Open

RSS feed torrent links with spaces aren't handled correctly #1213

SquirrelKiev opened this issue Oct 15, 2024 · 2 comments

Comments

@SquirrelKiev
Copy link

For example, an RSS feed with an item with a url of https://example.com/Super awesome episode.torrent, Taiga will attempt to download https://example.com/Super, which fails. This is particularly an issue on the erai raws RSS feed. Could just replace the spaces in the link with %20 before attempting the request?

@erengy
Copy link
Owner

erengy commented Oct 15, 2024

URLs cannot contain spaces, though. https://example.com/Super awesome episode.torrent is not a valid URL.

Unlike #1021, this is not about user input, so there shouldn't be a need to allow a more human-friendly syntax. Erai-Raws fixing their RSS feed makes more sense to me than Taiga and other applications adding a workaround for them. Standards exist so that there is prior agreement on how to communicate and we don't have to think about things like this.

That being said, this won't be an issue if v2 ends up using Qt's QUrl class for handling URLs. It works in TolerantMode by default, which accepts unencoded space characters.

@SquirrelKiev
Copy link
Author

SquirrelKiev commented Oct 23, 2024

Erai didn't seem interested in changing either, will switch to a different feed for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants