Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better qualify bad packets #8

Open
1 of 4 tasks
erelson opened this issue Jan 28, 2013 · 0 comments
Open
1 of 4 tasks

Better qualify bad packets #8

erelson opened this issue Jan 28, 2013 · 0 comments

Comments

@erelson
Copy link
Owner

erelson commented Jan 28, 2013

Currently we have the method is_bad_packet() which just evaluates if a packet is too short to contain the cmd/address byte. This might not even be valid, e.g. for status packets?

One case of bad packets I've seen is an 255 255 0 255 packet that showed up at the beginning of a log.

Other thoughts:

  • Include check-sum checking in this method?
  • Compare actual packet length (L+4) with the length byte (L)
  • packet not long enough for at least one value byte = bad?
  • does packet good/bad depend on the instruction byte?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant