refactor!: simplify application stack configuration

[sebastianlolv]

Checklist

• I've updated both the azurerm_linux_web_app and azurerm_windows_web_app resources.

Ref: equinor/terraform-baseline#126

[hknutsen]

I'd prefix the PR with refactor!, since it doesn't add or remove anything per se, instead it replaces a complex object variable with multiple simpler variables corresponding to the object properties. See Reviewing changes for reference.

[hknutsen]

Also removed the for Web Apps part from the PR title, since this change is being made in the Web App module repo 😅

Since this is now marked as a breaking change, it's important that we describe the breaking change in detail in the squash commit message, according to the Conventional Commits specification.

So the squash commit should look something like this:

refactor!: simplify application stack configuration

BREAKING CHANGE: replace complex type variable `application_stack` with simple
type variables `application_stack_docker_image_name`,
`application_stack_docker_registry_url`,
`application_stack_docker_registry_username`,
`application_stack_docker_registry_password` and `current_application_stack`.

^ Make sure it doesn't break the 80 character line limit.

[hknutsen]

Added some clarifications to variable descriptions.

Also, with the current implementation, the application_stack block will always be configured, while the previous implementation would only configure it when explicitly specified. We need to test if the current implementation breaks anything, or if we need to re-implement logic to create it dynamically when needed.

[hknutsen]

Followup... Module currently throws an error if not setting explicit values for any application stack variables, since it tries to create an empty application_stack block. We'll need to implement logic to only configure the application_stack block when needed.

[github-actions]

There has been no activity on this pull request for 60 days. stale label will be added. If no additional activity occurs, the pull request will be closed in 7 days.

[github-actions]

There has been no activity on this stale pull request for 7 days. This pull request will now be closed. If new activity occurs, the pull request will reopen.