-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change command line option name from cache to work #351
Conversation
094bd4d
to
c295b3c
Compare
Good stuff -- this is much needed! Wondering if this PR should just take on #294 ? I wasted a bunch of time figuring it out a few weeks ago (and failing!) and I'm guessing you (and Julius/Zohar I think) just burnt a bunch more time figuring it all out again. Maybe a sign that we can no longer afford this particular bit of debt. I guess I'm especially wondering if it's a good idea to introduce more words ( |
Yes. I even discovered the "workspace" option after having written this. "workspace" could possibly be the only allowed argument, and we can require it to be empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, much cleaner.
Oh, I guess style is failing, but I'm sure you'll fix that :D |
The command line option cache hints to komodo supporting some kind of caching, which it does not. The directory named used as a cache is a working directory used while building, and cannot be prepopulated.
The command line option cache hints to komodo supporting some kind of caching, which it does not. The directory named used as a cache is a working directory used while building, and cannot be prepopulated.