Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change command line option name from cache to work #351

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

berland
Copy link
Contributor

@berland berland commented Feb 23, 2023

The command line option cache hints to komodo supporting some kind of caching, which it does not. The directory named used as a cache is a working directory used while building, and cannot be prepopulated.

komodo/fetch.py Outdated Show resolved Hide resolved
komodo/cli.py Outdated Show resolved Hide resolved
@kwinkunks
Copy link
Member

Good stuff -- this is much needed!

Wondering if this PR should just take on #294 ? I wasted a bunch of time figuring it out a few weeks ago (and failing!) and I'm guessing you (and Julius/Zohar I think) just burnt a bunch more time figuring it all out again. Maybe a sign that we can no longer afford this particular bit of debt.

I guess I'm especially wondering if it's a good idea to introduce more words (work and workspace_for_downloads) especially as we already have workspace, which is something else again? Maybe download_directory is clearer?

@berland
Copy link
Contributor Author

berland commented Feb 23, 2023

Yes. I even discovered the "workspace" option after having written this. "workspace" could possibly be the only allowed argument, and we can require it to be empty.

Copy link
Member

@kwinkunks kwinkunks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, much cleaner.

@kwinkunks
Copy link
Member

Oh, I guess style is failing, but I'm sure you'll fix that :D

The command line option cache hints to komodo supporting some kind of
caching, which it does not. The directory named used as a cache is a working
directory used while building, and cannot be prepopulated.
@berland berland merged commit 47d430b into equinor:main Mar 6, 2023
@berland berland deleted the cache_to_work branch September 27, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants