Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Komodo-check-pypi should include additional dependencies added between versions #459

Open
jonathan-eq opened this issue Feb 6, 2024 · 2 comments

Comments

@jonathan-eq
Copy link
Collaborator

jonathan-eq commented Feb 6, 2024

There might be additional dependencies added between package versions. Komodo-check-pypi should include those, and also add them to the repository file. It should also remove dependencies not required by the new version.

@jonathan-eq jonathan-eq changed the title Komodo-check-pypi should include additional packages added between versions Komodo-check-pypi should include additional dependencies added between versions Feb 6, 2024
@jonathan-eq jonathan-eq self-assigned this Feb 6, 2024
@jonathan-eq jonathan-eq added this to SCOUT Feb 6, 2024
@jonathan-eq jonathan-eq moved this to In Progress in SCOUT Feb 6, 2024
@jonathan-eq
Copy link
Collaborator Author

It seems like pypi only gives dependency for the entire package, not the specific version. It also probably shows the requirements of the latest version, which is not always the one we want in case something is pinned.

@jonathan-eq jonathan-eq moved this from In Progress to Todo in SCOUT Feb 8, 2024
@jonathan-eq jonathan-eq removed their assignment Feb 8, 2024
@jonathan-eq
Copy link
Collaborator Author

We can check the dependencies of each release of a package through pypi (ex: https://pypi.org/pypi/pytest/8.0.0/json), but if we check every package, and every dependency, and every dependency of that dependency, we might get rate limited by pypi.

@jonathan-eq jonathan-eq removed the status in SCOUT Feb 8, 2024
@jonathan-eq jonathan-eq self-assigned this Feb 8, 2024
@jonathan-eq jonathan-eq moved this to In Progress in SCOUT Feb 8, 2024
@jonathan-eq jonathan-eq moved this from In Progress to Todo in SCOUT Feb 8, 2024
@jonathan-eq jonathan-eq removed their assignment Feb 13, 2024
@jonathan-eq jonathan-eq removed this from SCOUT Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant