Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'start_time' in 'InspectionMetadata' #368

Open
tsundvoll opened this issue Nov 24, 2022 · 4 comments
Open

Remove 'start_time' in 'InspectionMetadata' #368

tsundvoll opened this issue Nov 24, 2022 · 4 comments
Labels
breaking-change A breaking change which introduces changes to the public APIs improvement Improvement to existing functionality stale This issue or pull request already exists

Comments

@tsundvoll
Copy link
Contributor

tsundvoll commented Nov 24, 2022 •
edited
Loading

Describe the improvement you would like to see
Remove the 'start_time' attribute from the 'InspectionMetadata' class in 'src/robot_interface/models/inspection/inspection.py'. Time is anyways baked into the 'time_indexed_pose' attribute. Remember to update everywhere the class is used, also in the different robot repositories.

How will this change existing functionality?
I can't see that start time is used anywhere now, so it will not break any existing functionality.
@tsundvoll tsundvoll added the improvement Improvement to existing functionality label Nov 24, 2022
@tsundvoll tsundvoll changed the title Remove Remove 'start_time' in 'InspectionMetadata' Nov 24, 2022
@aeshub
Copy link
Contributor

aeshub commented Jan 24, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jan 24, 2023
@Christdej Christdej mentioned this issue Feb 8, 2023
Merged
@Christdej
Copy link
Contributor

Would it make more sense to change TimeIndexedPose to Pose and keep "start_time"?

@Christdej Christdej removed the stale This issue or pull request already exists label Feb 15, 2023
@aeshub
Copy link
Contributor

aeshub commented Jun 20, 2023

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jun 20, 2023
@andchiind andchiind added the breaking-change A breaking change which introduces changes to the public APIs label Sep 3, 2024
@aeshub aeshub removed the stale This issue or pull request already exists label Sep 5, 2024
@aeshub
Copy link
Contributor

aeshub commented Nov 4, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change A breaking change which introduces changes to the public APIs improvement Improvement to existing functionality stale This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aeshub @andchiind @tsundvoll @Christdej