Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE-66 ✨ 회원가입 페이지 api #59

Merged
merged 8 commits into from
Jul 25, 2024
Merged

FE-66 ✨ 회원가입 페이지 api #59

merged 8 commits into from
Jul 25, 2024

Conversation

jangmoonwon
Copy link
Contributor

🔖 Issue Ticket

Ticket

✍️ Description

  • 회원가입 페이지 api 연동

✅ Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

유효한 이메일, 비밀번호, 비밀번호 확인, 닉네임을 적은 경우
화면-기록-2024-07-23-오후-3 33 03

이메일 중복인 경우
스크린샷 2024-07-23 오후 3 35 23

닉네임 중복인 경우
스크린샷 2024-07-23 오후 3 35 44

네트워크 오류
스크린샷 2024-07-23 오후 3 36 55

Additional Notes

  • 간편 회원가입 작업

@jangmoonwon jangmoonwon added Priority: Medium 🔖 우선순위 보통 Type: Feature ✨ 신규 기능 labels Jul 23, 2024
@jangmoonwon jangmoonwon requested a review from a team July 23, 2024 07:06
@jangmoonwon jangmoonwon self-assigned this Jul 23, 2024
imsoohyeok
imsoohyeok previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@imsoohyeok imsoohyeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 고생하셨습니다

jangmoonwon and others added 2 commits July 24, 2024 20:03
@jangmoonwon jangmoonwon requested a review from a team July 24, 2024 12:38
newjinlee
newjinlee approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@newjinlee newjinlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
고생하셨습니다 ~

@jangmoonwon jangmoonwon merged commit a367f41 into epic/FE-66 Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newjinlee newjinlee newjinlee approved these changes

@imsoohyeok imsoohyeok imsoohyeok left review comments

Assignees

@jangmoonwon jangmoonwon

Labels
Priority: Medium 🔖 우선순위 보통 Type: Feature ✨ 신규 기능
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jangmoonwon @newjinlee @imsoohyeok