Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all priors to new dist interface, not just delays #525

Closed
sbfnk opened this issue Nov 30, 2023 · 3 comments · Fixed by #871
Closed

Change all priors to new dist interface, not just delays #525

sbfnk opened this issue Nov 30, 2023 · 3 comments · Fixed by #871
Assignees

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Nov 30, 2023

          For a future PR this should probably be updated to use `normal()`.

Originally posted by @seabbs in #504 (comment)

This will require moving the conversion to discretised distribution to the processing for stan (which is possibly a good idea anyway).

@sbfnk
Copy link
Contributor Author

sbfnk commented Feb 12, 2024

Will be picked up once #504 is merged.

@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented May 22, 2024

The linked comment does not lead anywhere so I'm struggling to get the context. I came here after seeing the code chunk here probably needs to be updated to use the new distribution interface.

Found the comment: https://github.com/epiforecasts/EpiNow2/pull/504/files#r1408162989 (Note to future James: It takes a second to load, so wait a little.)

@sbfnk sbfnk self-assigned this May 28, 2024
@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented Jul 1, 2024

The linked comment does not lead anywhere so I'm struggling to get the context. I came here after seeing the code chunk here probably needs to be updated to use the new distribution interface.

Found the comment: #504 (files) (Note to future James: It takes a second to load, so wait a little.)

I'm paraphrasing the context of the linked comments here because it takes a while to load, giving the impression that the comment is lost:

In the current implementation of rt_opts(), the prior argument is specified as a list instead of Normal(), so @seabbs suggests to update to use the current EpiNow2::Distributions() interface.

@sbfnk says: "Agree in principle though this would probably require extension of the distribution interface to not automatically discretise, or only to discretise when converting to stan code (possibly a good idea anyway?)."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants