Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.4 Release check list #354

Closed
13 of 16 tasks
seabbs opened this issue Jan 25, 2023 · 3 comments
Closed
13 of 16 tasks

1.3.4 Release check list #354

seabbs opened this issue Jan 25, 2023 · 3 comments
Assignees

Comments

@seabbs
Copy link
Contributor

seabbs commented Jan 25, 2023

The only outstanding issue I haven't dealt with flagged by CRAN is the long running examples. Their complaint was that all examples (including those flagged as don't test) took over 3 hours on their machine and that this was ridiculous. Given that 1. it only takes an hour in our CI and 2. it isn't like a user runs every example I am minded to take no action and hope they don't flag it again (it only came up because we were arguing about if the package writes to the users directory and some point scoring was needed).

@seabbs

This comment was marked as outdated.

@seabbs

This comment was marked as outdated.

@seabbs

This comment was marked as outdated.

@seabbs seabbs closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants