Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model 3 driver for class 4 and 5 SmartMotors #1

Open
klauer opened this issue Jun 18, 2019 · 2 comments
Open

Model 3 driver for class 4 and 5 SmartMotors #1

klauer opened this issue Jun 18, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@klauer
Copy link

klauer commented Jun 18, 2019

The SLAC accelerator has worked a considerable amount with the Animatics SmartMotors, as they are used extensively in the LCLS and now the LCLS-II undulator hall.

There have been many changes in the SLAC accelerator motor fork that brings a number of improvements to the motor record support:

https://github.com/klauer/motor/commits/smartmotor_R6-10

The model 3 driver adds:

  • SmartMotor class 4/5 support
  • CANbus-based multi-axis support with a virtual axis
  • Automatic communication re-sync after a failure
  • PID settings, overcurrent/overtemperature monitoring, etc.

I made an attempt to pull those commits out from the accelerator fork to bring the work back to the collaboration, but failed to do that while I still had access to the hardware. As-is, this would likely need some work before a PR could be opened. Feel free to close this issue if not relevant.

cc @alexmontironi

@kmpeters kmpeters added the enhancement New feature or request label Aug 8, 2019
@kmpeters
Copy link
Contributor

If SLAC wants to share a link to the newer version of the SmartMotor support, I'm happy to include it here.

@klauer
Copy link
Author

klauer commented Apr 13, 2023

Ping @alexmontironi (the new lead for this effort as I no longer work with SmartMotors; but I'd be happy to help her with this if I can)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants