Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render tourism=camp_pitch #144

Closed
habi opened this issue Oct 18, 2022 · 3 comments
Closed

Render tourism=camp_pitch #144

habi opened this issue Oct 18, 2022 · 3 comments
Assignees
Labels
bug Something that went wrong icon Icon requests and other icon related issues

Comments

@habi
Copy link

habi commented Oct 18, 2022

It would be great if tourism=camp_pitch is rendered, maybe even with its refnumber if mapped.
A (faint) border could be something appropriate.

Somehow related to me wanting to render a detailed map of campsites...

@enzet
Copy link
Owner

enzet commented Oct 20, 2022

Good suggestion, thank you!

@enzet enzet added the icon Icon requests and other icon related issues label Oct 20, 2022
@enzet enzet moved this to Todo in Project support Oct 20, 2022
enzet added a commit that referenced this issue Oct 25, 2022
@enzet enzet moved this from Todo to In Progress in Project support Oct 25, 2022
enzet added a commit that referenced this issue Oct 25, 2022
Use simple outline for a camp pitch if it is an area.
@enzet
Copy link
Owner

enzet commented Oct 25, 2022

Hi, @habi! I've fixed a bug with the ref tag and supported tourism=camp_pitch with simple outline if this is an area.

Now it should look like this:

map-machine render -s 600,400 -c 46.80506/6.71758 -z 19

camp_pitch_19_ref

map-machine render -s 600,400 -c 46.80506/6.71758

camp_pitch_18_ref

Using an icon

If we want to use an icon, we should specify its minimal zoom level. I think, 19 is most appropriate.

camp_pitch_19_icon

However, due to some limitations of currently used scheme format, for zoom levels 18 and smaller, icons will disapear along with refs.

camp_pitch_18_icon

@enzet enzet self-assigned this Oct 25, 2022
@enzet enzet added the bug Something that went wrong label Oct 25, 2022
enzet added a commit that referenced this issue Oct 25, 2022
For caravans=yes and tents=yes.
enzet added a commit that referenced this issue Oct 25, 2022
For fireplace=yes and openfire=yes.
@enzet enzet moved this from In Progress to Review From Author Needed in Project support Oct 25, 2022
@habi
Copy link
Author

habi commented Oct 26, 2022

I think it's very nice that camp pitches are now rendered as faintly visible ways, thanks for implementing this so quickly!

@habi habi closed this as completed Oct 26, 2022
Repository owner moved this from Review From Author Needed to Done in Project support Oct 26, 2022
enzet added a commit that referenced this issue Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that went wrong icon Icon requests and other icon related issues
Projects
Status: Done
Development

No branches or pull requests

2 participants