Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer package upgrades #767

Closed
13 of 15 tasks
stwalkerster opened this issue Sep 6, 2022 · 5 comments
Closed
13 of 15 tasks

Composer package upgrades #767

stwalkerster opened this issue Sep 6, 2022 · 5 comments
Labels
actually quite difficult This task has technical intricacies which mean it needs analysis by someone familiar with the system

Comments

@stwalkerster
Copy link
Member

stwalkerster commented Sep 6, 2022

We should consider upgrading the following packages:

Semi-relevant but old information
  • smarty/smarty => ^v4.2.0
  • twbs/bootstrap => ^5.2
  • fortawesome/font-awesome => ^6.2
  • spomky-labs/otphp => ^v11.0
  • wikimedia/common-passwords => ^v0.4
  • league/commonmark => ^2.3

Some of these (wikimedia/common-passwords, league/commonmark) should be fairly straight-forward since they're used in very specific and easily-testable ways.

Others (spomky-labs/otphp) have security considerations, and need to be very well tested as well as ensuring existing TOTP codes work.

More still (smarty/smarty, fortawesome/font-awesome) are so ingrained into the UI of the tool that a change will require retesting pretty much every page in the tool.

Finally, twbs/bootstrap will have some major breaking changes, and will likely require substantial fiddling around with SCSS to do the upgrade.


Most of the minor upgrades will be dealt with by @dependabot. Some of the more major updates will require more work.

General list of additional work

  1. dependencies php
  2. good first issue
  3. 1 of 2
    actually quite difficult scss
  4. dependencies
    stwalkerster
  5. dependencies
  6. dependencies
    stwalkerster
  7. dependencies
    stwalkerster
  8. dependencies
  9. dependencies
    stwalkerster
  10. dependencies
    stwalkerster
  11. dependencies
    stwalkerster
  12. dependencies
    stwalkerster
  13. dependencies
    stwalkerster
  14. dependencies
@stwalkerster stwalkerster added the actually quite difficult This task has technical intricacies which mean it needs analysis by someone familiar with the system label Sep 6, 2022
@methecooldude
Copy link
Member

font-awesome should be easy enough, the fonts haven't really changed

@dqwiki
Copy link
Member

dqwiki commented Dec 21, 2022

Would creating a PR for this help so we can at least run through the existing tests in the system plus set it up on a dev server and start seeing what's broken?

@stwalkerster
Copy link
Member Author

I don't think we should put all of these in one pull request, but having a series of PRs we can test is fine by me.

The four groups I listed above would make a good starting point so we're not creating thousands of PRs

@stwalkerster
Copy link
Member Author

So I'm basically working through this list with the assistance of dependabot. I'll update the main description with the current status.

@stwalkerster
Copy link
Member Author

I'm gonna close this as Dependabot has worked it's way through everything, except the ones that have different tasks opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actually quite difficult This task has technical intricacies which mean it needs analysis by someone familiar with the system
Projects
Archived in project
Development

No branches or pull requests

3 participants