(rbac) add principal matchers for dynamic downstream IPs #37374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ourced downstream IPs Signed-off-by: antoniovleonti <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: (rbac) add principal matchers for dynamic downstream IPs
Additional Description:
This PR adds two matchers to RBAC (filter_state_ip, dynamic_metadata_ip) which compare an IP from filter state / dynamic metadata to a CIDR block. If the IP is not found where specified in configuration, the matcher fails. The IP is assumed to be a downstream IP, so the matchers are principal matchers.
Risk Level: low
Testing: unit tested
Docs Changes: none
Release Notes: changelog updated
Platform Specific Features: none