fix: Default branch doesn't show environments #65
Conversation
Show environments without branch when the current branch is the default branch
fix tests
…ranch-doesn't-show-environments
Get cannot find environments error message from errors
| const calls = showErrorMessageSpy.mock.calls.filter( | ||
| (call) => | ||
| !( | ||
| call[0].startsWith(cannotGetDefaultBranchMessage) || | ||
| call[0].startsWith(getDefaultBranchErrorMessage) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
what errors? I don't understand this one
There was a problem hiding this comment.
Since the simple-git library is imported into the code before the test files load, making it impossible to mock, I am encountering error messages in the tests for getting the default branch. Therefore, I need to ignore the cannotGetDefaultBranchMessage and getDefaultBranchErrorMessage messages.
There was a problem hiding this comment.
Wdym by its loaded before the test file? how is it different from other libs?
| return undefined; | ||
| } | ||
|
|
||
| const remoteShowOrigin: string = await git.raw([ |
There was a problem hiding this comment.
what does remoteShowOrigin mean?
I don't really understand how this functions works, can you explain?
There was a problem hiding this comment.
There was a problem hiding this comment.
I see, so the var name is a little misleading, can't it just be default branch? ( or maybe repo default branch )
| return { | ||
| repository: normalizedRepositoryName, | ||
| currentBranch, | ||
| isDefaultBranch, |
There was a problem hiding this comment.
If its always used when this func is used then its fine imo ( but if its sometimes needed and sometimes it doesn't id remove it to its own func, because it doesn't really depend on anything here )
…ranch-doesn't-show-environments
problem:
Default branch doesn't show environments
Solution:
show env0 environments without blueprintRevision when current branch is the default branch
used git-simple to get the default branch
updated readme and errors accordingly
before:
after:
after when no envs to display
