Fix: add pagination for teams api #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Nov 19, 2024
client/environment.go
Outdated
| @@ -233,24 +233,20 @@ type EnvironmentDeployResponse struct { | |||
| Id string `json:"id"` | |||
| } | |||
|
|
|||
| func (Environment) getEndpoint() string { | |||
There was a problem hiding this comment.
not needed... I do it in a different way.
TomerHeber
commented
Nov 19, 2024
client/pagination.go
Outdated
| @@ -29,7 +24,7 @@ func (p *Pagination) next(currentPageSize int) bool { | |||
| } | |||
|
|
|||
| // params - additional params. may be nil. | |||
| func getAll[P Paginated](client *ApiClient, params map[string]string) ([]P, error) { | |||
| func getAll[P any](client *ApiClient, endpoint string, params map[string]string) ([]P, error) { | |||
There was a problem hiding this comment.
modified to support all types.
TomerHeber
commented
Nov 19, 2024
TomerHeber
force-pushed
the
fix-add-team-pagination-#981
branch
from
c1f4247
to
4ddf679
Compare
TomerHeber
force-pushed
the
fix-add-team-pagination-#981
branch
from
f691769
to
4599af4
Compare
|
/review |
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #981
Solution
Added pagination for teams() api call.
Minor updates to code to add the pagination.
Updated unit tests.