Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seal the SchemeParameters trait #74

Open
fjarri opened this issue Nov 19, 2023 · 0 comments
Open

Seal the SchemeParameters trait #74

fjarri opened this issue Nov 19, 2023 · 0 comments
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Nov 19, 2023

The user doesn't need to know what's happening in there, and it will facilitate changes later on. See https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed

@fjarri fjarri added API Involves backwards-incompatible changes of the public API code quality Making things simpler labels Nov 19, 2023
@fjarri fjarri added this to the v1.0.0 milestone Nov 26, 2023
@fjarri fjarri mentioned this issue Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Projects
None yet
Development

No branches or pull requests

1 participant