Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for intiating attestations via the propagation pallet / offchain worker #1181

Open
ameba23 opened this issue Nov 22, 2024 · 0 comments
Milestone

Comments

@ameba23
Copy link
Contributor

ameba23 commented Nov 22, 2024

We have some code which is not currently used for anything since we changed the way attestations are initiated.

The chainspec, propagation pallet, and threshold signature server have code relating to triggering attestations which is no longer needed, including two ignored tests in entropy-tss.

Im not sure if we should go ahead and remove this code, or wait until we are totally clear on our attestation design. I feel like there is still a little bit of uncertainty as to whether more frequent attestation will be needed.

If this still isn't clear at the point of making the next release i would remove it.

Related to #982

@ameba23 ameba23 added this to the v0.4.0 milestone Nov 22, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Entropy Core Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant