-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added build step in circle CI #292
base: master
Are you sure you want to change the base?
Conversation
Oh hey, nice. Would anybody with Docker expertise like to review? |
Yeah, I too don't have much of docker expertise, just went through circleCI docs, would love any review and/or resources to follow. |
Related issue: #281 @nveenjain can you add |
6992651
to
9d905ee
Compare
I think that build got stuck in a loop. #259 might be the fix, if you get up to date with upstream master I think that'll work. |
9d905ee
to
4f3fe94
Compare
Ok thanks, will try that!!! |
4f3fe94
to
3655723
Compare
Looks like it is missing some environment variables, we could setup these environment variables in CI. |
3655723
to
fdc8d9f
Compare
The issue here, I think, is actually that the docker-compose file points to |
1d964b6
to
9a83cbe
Compare
I debugged this over on my own Circle and had some suggestions. |
9a83cbe
to
29fb95f
Compare
29fb95f
to
187933a
Compare
This looks good! Should definitely help prevent breaking the dev setup in the future. |
Change Type (Feature, Chore, Bug Fix, One Pager, etc.)
Added support to test docker-compose in circle CI
Description
Fixes #281
How to test
CircleCI will run build step automatically on this PR i guess..
Checklist
NA