Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build step in circle CI #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nveenjain
Copy link

@nveenjain nveenjain commented Jun 21, 2019

Change Type (Feature, Chore, Bug Fix, One Pager, etc.)

Added support to test docker-compose in circle CI

Description

Fixes #281

How to test

CircleCI will run build step automatically on this PR i guess..

Checklist

NA

  • Added tests / did not decrease code coverage
  • Tested in supported environments (common browsers or current Node)

@ceejbot
Copy link
Collaborator

ceejbot commented Jun 21, 2019

Oh hey, nice. Would anybody with Docker expertise like to review?

@nveenjain
Copy link
Author

Yeah, I too don't have much of docker expertise, just went through circleCI docs, would love any review and/or resources to follow.
Looking through the code of main repo now, so that I can contribute to this awesome idea more.

@zacanger
Copy link
Contributor

zacanger commented Jun 21, 2019

Related issue: #281

@nveenjain can you add - build to workflows.everything.jobs at the bottom of the file? That'll add your new job to the list of jobs that get run.

@nveenjain nveenjain force-pushed the test/docker_compose branch from 6992651 to 9d905ee Compare June 21, 2019 19:09
@zacanger
Copy link
Contributor

I think that build got stuck in a loop. #259 might be the fix, if you get up to date with upstream master I think that'll work.

@nveenjain nveenjain force-pushed the test/docker_compose branch from 9d905ee to 4f3fe94 Compare June 21, 2019 19:20
@nveenjain
Copy link
Author

nveenjain commented Jun 21, 2019

Ok thanks, will try that!!!

@nveenjain nveenjain force-pushed the test/docker_compose branch from 4f3fe94 to 3655723 Compare June 21, 2019 19:23
@nveenjain
Copy link
Author

Looks like it is missing some environment variables, we could setup these environment variables in CI.
docker/compose#4189 (comment)
If they are already set, then docker/compose#4189 (comment) might fix.. I'll try the second one now...

@nveenjain nveenjain force-pushed the test/docker_compose branch from 3655723 to fdc8d9f Compare June 21, 2019 19:30
@zacanger
Copy link
Contributor

The issue here, I think, is actually that the docker-compose file points to .env files in the services, but those are usually created manually by users based on the .env-example files. Adding in a step before docker-compose up that copies each of those would probably work.

@nveenjain nveenjain force-pushed the test/docker_compose branch 2 times, most recently from 1d964b6 to 9a83cbe Compare June 21, 2019 19:51
@zacanger
Copy link
Contributor

I debugged this over on my own Circle and had some suggestions.

@nveenjain nveenjain force-pushed the test/docker_compose branch from 9a83cbe to 29fb95f Compare June 22, 2019 00:52
@nveenjain nveenjain force-pushed the test/docker_compose branch from 29fb95f to 187933a Compare June 22, 2019 00:53
@zacanger
Copy link
Contributor

This looks good! Should definitely help prevent breaking the dev setup in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests for docker-compose
3 participants