Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Illegal char 🥺 #1288

Open
the-emerald opened this issue Oct 5, 2021 · 6 comments
Open

Error: Illegal char 🥺 #1288

the-emerald opened this issue Oct 5, 2021 · 6 comments

Comments

@the-emerald
Copy link

Describe the bug
I own the domain name 🥺👉 👈.eth. However, the emoji is incorrectly treated as an invalid character. #1167 is supposed to have fixed this, however the issue persists.

To Reproduce
Steps to reproduce the behavior:

  1. Log in as esmeralda.eth
  2. See all domains
  3. A white screen appears.

Expected behavior
I should be able to see my domain names.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox
  • Version 92.0.1 (64-bit)

Additional context
Add any other context about the problem here.

@makoto
Copy link
Member

makoto commented Oct 27, 2021

The name you posted has whitespace between two emojis and whitespace is invalid.
Screenshot 2021-10-27 at 10 30 25

If it should suppose to display different emoji, can you paste the screenshot and any platform it can display correctly?
It's a bit odd that you managed to register the name which you can't even display on our app unless a bug was introduced after you registered the name.

@the-emerald
Copy link
Author

the-emerald commented Oct 27, 2021

Unfortunately the whitespace in my original comment was a typo. The punycode does not match the string that was used for registration! It is xn-- -e52sba924c but the string passed into registration contract call is

[7]:  786e2d2d74703868623030316200000000000000000000000000000000000000

according to etherscan.

@the-emerald
Copy link
Author

the-emerald commented Oct 27, 2021

#1167 (comment)

I was able to use this fix by forking the repos and updating the dependencies manually, then serving the site locally to register the domain name with the string above.

I assume the issue is that said string is the literal punycode for 🥺👉👈, however I should have registered with the actual emojis as the string text?

I should note that right now, the website functions properly again, but I cannot see said domain name anywhere, even though it says I can set up a reverse record for it on the site - it does not show up under the list of domain names I own.

@makoto
Copy link
Member

makoto commented Oct 28, 2021

I cannot see said domain name anywhere if you look into the transaction that registered the name, you should be able to see the label of the name you registered and tokenId which you can directly refer on opensea to see if the said name actually exists

@makoto
Copy link
Member

makoto commented Oct 28, 2021

eg
Screenshot 2021-10-28 at 11 51 51

@the-emerald
Copy link
Author

the-emerald commented Oct 28, 2021

Here's the transaction: https://etherscan.io/tx/0xbf4a41a71d300dd426b307782e6c923ce3b0ad8c499284eaaa6c1b101d6d9430

What I meant to say is - it does not show up on the dapp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants