A bug of fullscreen and WebGPU?

[SetoKaiba]

When I use the WebGPU basic rendering, I click the fullscreen button. The canvas is set to zero width and height.

emscripten/src/library_browser.js

Line 409 in 77da629

Browser.updateCanvasDimensions(canvas);

When the full screen button is clicked, this function is called. And it will call into updateCanvasDimensions.

emscripten/src/library_browser.js

Lines 732 to 777 in 77da629

	updateCanvasDimensions : function(canvas, wNative, hNative) {
	if (wNative && hNative) {
	canvas.widthNative = wNative;
	canvas.heightNative = hNative;
	} else {
	wNative = canvas.widthNative;
	hNative = canvas.heightNative;
	}
	var w = wNative;
	var h = hNative;
	if (Module['forcedAspectRatio'] && Module['forcedAspectRatio'] > 0) {
	if (w/h < Module['forcedAspectRatio']) {
	w = Math.round(h * Module['forcedAspectRatio']);
	} else {
	h = Math.round(w / Module['forcedAspectRatio']);
	}
	}
	if (((document['fullscreenElement'] || document['mozFullScreenElement'] ||
	document['msFullscreenElement'] || document['webkitFullscreenElement'] ||
	document['webkitCurrentFullScreenElement']) === canvas.parentNode) && (typeof screen != 'undefined')) {
	var factor = Math.min(screen.width / w, screen.height / h);
	w = Math.round(w * factor);
	h = Math.round(h * factor);
	}
	if (Browser.resizeCanvas) {
	if (canvas.width != w) canvas.width = w;
	if (canvas.height != h) canvas.height = h;
	if (typeof canvas.style != 'undefined') {
	canvas.style.removeProperty( "width");
	canvas.style.removeProperty("height");
	}
	} else {
	if (canvas.width != wNative) canvas.width = wNative;
	if (canvas.height != hNative) canvas.height = hNative;
	if (typeof canvas.style != 'undefined') {
	if (w != wNative || h != hNative) {
	canvas.style.setProperty( "width", w + "px", "important");
	canvas.style.setProperty("height", h + "px", "important");
	} else {
	canvas.style.removeProperty( "width");
	canvas.style.removeProperty("height");
	}
	}
	}
	},
	},

wNative and hNative is not set. They will be set to the canvas.widthNative and canvas.heightNative. But there're no widthNative and heightNative as well.
I think the problem is canvas.widthNative and canvas.heightNative is never set.

I can make it working by add this line.
emscripten_set_canvas_size(kWidth,kHeight);
But the emscripten_set_canvas_size is deprecated. If I use the emscripten_set_canvas_element_size, it doesn't set the canvas.widthNative and canvas.heightNative. Then the fullscreen is not working.

xlib, glut, sdl, glfw will all call Browser.setCanvasSize. But the webgpu just get a SurfaceDescriptorFromCanvasHTMLSelector . So it doesn't need the initialize with library_xxx.js. Then the canvasSize is never set.

Is it a bug? Should I submit a bug report?

[sbc100]

@kainino0x

[kainino0x]

This sounds like a bug, unfortunately despite being one of the maintainers of the WebGPU bindings in Emscripten (cc @shrekshao) I'm not familiar enough with Emscripten's canvas code to know how to do this correctly. Please go ahead and file a bug.

[SetoKaiba]

#17522
@kainino0x I created an issue. But it seems no one repies.