New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreachable code at SignedInteger.java:[line 102] #2

Open

hallo02 opened this issue Mar 7, 2017 · 1 comment

hallo02 commented Mar 7, 2017

else if (smallValue < Short.MAX_VALUE && smallValue > Short.MAX_VALUE) {
length = 2;
}

should be

else if (smallValue < Short.MAX_VALUE && smallValue > Short.MIN_VALUE) {
length = 2;
}

isn't it?

Collaborator

mlohbihler commented Mar 8, 2017

Yes, it should. Thanks. I've made this change in v4. (Not yet committed at this moment.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment