Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AttErrorCode enum with newtype wrapping u8 #161

Open
petekubiak opened this issue Nov 8, 2024 · 0 comments
Open

Replace AttErrorCode enum with newtype wrapping u8 #161

petekubiak opened this issue Nov 8, 2024 · 0 comments

Comments

@petekubiak
Copy link
Collaborator

          I think we should consider making this a newtype wrapping `u8` with associated constants, rather than an enum. When a client sends a request to a remote server that server can theoretically return any error code it wants, regardless of the spec. For example, if it's a server that supports a newer version of the spec than trouble it could return a code unknown to trouble.

Originally posted by @alexmoon in #151 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant