Installation Instructions and Code do not match

[mementum]

The code is looking for grammarly-ls on the PATH. But the binary which is installed by npm is grammarly-languageserver. This means that if the binary is installed manually as indicated by the general lsp-mode instructions, the binary will never be found

If looking for the binary of the auto-installed it will also fail if running for example under cygwin, because npm will install the binary directly under the {prefix}, but the entire lsp-mode chain is looking for the binary under {prefix}/bin

Note: it only runs for a few seconds and then exists ... but this is for another repository.

[mementum]

lsp-grammarly/lsp-grammarly.el

Lines 419 to 423 in 6f4c523

	(lsp-dependency 'grammarly-ls
	'(:system "grammarly-ls")
	'(:npm :package "@emacs-grammarly/grammarly-languageserver"
	:path "grammarly-languageserver"))

Notice the :system grammarly-ls, which is what is being sought system-wide (using the PATH), but there is no such binary/script in the @emacs-grammarly/grammarly-languageserver package.

[jcs090218]

The code is looking for grammarly-ls on the PATH. But the binary which is installed by npm is grammarly-languageserver. This means that if the binary is installed manually as indicated by the general lsp-mode instructions, the binary will never be found

Yeah, you are right. It's been a while, so I don't remember why I coded the binary name like this. 😅

If looking for the binary of the auto-installed it will also fail if running for example under cygwin, because npm will install the binary directly under the {prefix}, but the entire lsp-mode chain is looking for the binary under {prefix}/bin

I'm unsure about this since I am unfamiliar with Cygwin's settings. This is the Grammarly language server installed path look like on macOS:

~/.emacs.d/.cache/lsp/npm/@emacs-grammarly/grammarly-languageserver/bin/grammarly-languageserver/