Delegate libvips processing to ImageProcessing gem #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janko
force-pushed
the
replace-with-image_processing
branch
from
3f5c514
to
50e393d
Compare
ImageProcessing gem is a wrapper gem around MiniMagick and libvips, which implements common resizing macros. Instead of the carrierwave-vips project having to maintain those macros, it can use the ImageProcessing to do the heavy lifting. The ImageProcessing gem will constantly get updated with best practices for image processing, so any bug fixes and performance improvements there will automatically benefit carrierwave-vips. The ImageProcessing gem automatically pulls in ruby-vips ">= 2.0.10" as a dependency, so we remove it from the gemspec. ImageProcessing uses the improved vips_thumbnail(), so it depends on libvips 8.6+. This PR additionally adds the `#resize_to_pad` method.
janko
force-pushed
the
replace-with-image_processing
branch
from
50e393d
to
65b74b5
Compare
|
I'm not using Ruby a whole lot these days. Feel free to use the code to make a new gem with ImageProcessing based on this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageProcessing gem is a wrapper gem around MiniMagick and libvips, which implements common resizing macros. Instead of the carrierwave-vips project having to maintain those macros, it can use the ImageProcessing to do the heavy lifting. The ImageProcessing gem will constantly get updated with best practices for image processing, so any bug fixes and performance improvements there will automatically benefit carrierwave-vips.
The ImageProcessing gem automatically pulls in ruby-vips
>= 2.0.10as a dependency, so we remove it from the gemspec. ImageProcessing uses the improvedvips_thumbnail(), so it depends on libvips 8.6+. It also usesvips_autorot()for autorotation.This PR additionally adds the
#resize_to_padmethod.Closes #28
Closes #27
Closes #19