Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support auto_rotate #19

Open
jcupitt opened this issue Mar 30, 2014 · 9 comments
Open

support auto_rotate #19

jcupitt opened this issue Mar 30, 2014 · 9 comments

Comments

@jcupitt
Copy link
Contributor

jcupitt commented Mar 30, 2014

See libvips/ruby-vips#53

vipsthumbnail now has an autorotate feature, it might be possible to use part of that for ideas.

https://github.com/jcupitt/libvips/blob/master/tools/vipsthumbnail.c#L138

@arkmediastudio
Copy link

@eltiare sorry to ping you directly, Is it possible for us to get this feature added?.

Thank You.

@eltiare
Copy link
Owner

eltiare commented Apr 16, 2014

No worries, I've been a bit busy with work and taking care of a sick wife. I'll get this here fairly soon.

@arkmediastudio
Copy link

No problem, i will wait. Thank you for making this gem. 👍

@arkmediastudio
Copy link

I am still waiting for this . Can you please see lovell/sharp@a94dd2b if that helps to implement the feature in carrierwave-vips.

Thank You

@eltiare
Copy link
Owner

eltiare commented Jun 19, 2014

I'm running into problems reading the EXIF data. I've added comments on libvips/ruby-vips#53

@eltiare
Copy link
Owner

eltiare commented Jun 19, 2014

Thanks to @jcupitt I got the issue resolved. Can you please test to make sure that it works properly for you? Be sure to use the code in the master branch on Github as I've not yet pushed the changes to RubyGems.

@jcupitt
Copy link
Contributor Author

jcupitt commented Jul 12, 2014

I looked over the code and it seems reasonable, but I don't have a good carrierwave test setup so I didn't actually test it. Someone with a nice set of test images should try it and report.

@arkmediastudio
Copy link

hi @eltiare i have tested it but couldn't get this working. i am testing this using https://github.com/eltiare/carrierwave-vips/blob/master/spec/fixtures/portrait-with-orientation.jpg image, no errors are shown but it doesn't orient correctly in img tag in html. when i goto version directory using file browser i can see it orient correctly and when i open image using image viewer it shows correctly. but when put inside a img tag the orientation is wrong. how can i help you to debug this issue?. i am using github master branch of the this gem and ruby vips version is 0.3.9 and i am on ubuntu 14.04

@arkmediastudio
Copy link

why we remove orientation metadata in auto_orient in #L69 ?. i also tried without removing it and also setting it to 1 but nothing works

junegunn added a commit to junegunn/carrierwave-vips that referenced this issue Jul 19, 2015
And do not unset EXIF tags when reorientation is not needed. Close eltiare#19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants