Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small files can skew upload time statistics #18

Open
elonen opened this issue Jan 29, 2020 · 2 comments
Open

Small files can skew upload time statistics #18

elonen opened this issue Jan 29, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@elonen
Copy link
Owner

elonen commented Jan 29, 2020

In a small swarm, if a peer uploads a lot of small chunks, it will get unprortionally good upload time stats. Maybe change the statistics to bitrate instead (and calculate timeouts from there) to avoid this?

@elonen elonen added bug Something isn't working enhancement New feature or request labels Jan 29, 2020
@elonen
Copy link
Owner Author

elonen commented Jan 29, 2020

Slow downloaders can still skew it, but it's one less error source.

@elonen elonen changed the title Different sized files can skew upload time statistics Small files can skew upload time statistics Feb 3, 2020
@elonen
Copy link
Owner Author

elonen commented Feb 3, 2020

Alternatively (to using bandwidth as score), fileio.upload_chunk() could always normalize upload times as if upload had been of max chunk_size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant