Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit the contents of the mlang tags #9

Open
mudrd8mz opened this issue Jan 28, 2016 · 4 comments
Open

Can't edit the contents of the mlang tags #9

mudrd8mz opened this issue Jan 28, 2016 · 4 comments

Comments

@mudrd8mz
Copy link

The plugin works well when I type the text first, select it and then press the button to wrap it by the {mlang} tags.
But when I press the button first, without having any text selected, the button creates just empty {mlang xx}{mlang} block and I can't simply go and type something within them. It seems to me that whatever I do with the cursor (be it pressing arrows or clicking by mouse), it always highlights the whole mlang tag. So typing effectively overwrites it which is annoying.

@mudrd8mz
Copy link
Author

This is a screenshot. In other words, I found it difficult (if not impossible) to put the cursor between they yellow tags so that I can type the contexts there.

screenshot_2016-01-28_13-00-45

Browser: Chrome 48.0.2564.82 (64-bit)

@eljulians
Copy link
Owner

Hi again David,
I didn't notice that behavior while developing. I'll fix it as quick as possible to resubmit the plugin to the directory.

Thanks a lot for your time.

@mudrd8mz
Copy link
Author

It is slightly better yet no ideal in Firefox 43.0/Linux - I am able to use arrows at least to get in between the tags, while remaining as if the text was part of it.

screenshot_2016-01-28_13-04-24

eljulians pushed a commit that referenced this issue Jan 28, 2016
Also removed <span> tags for content in "TEMPLATE" since they are unnecessary.
@eljulians
Copy link
Owner

I've fixed it adding by default a   character if there's no text selected. I've not found a way to place the cursor between the right closing </span> tag and the left starting <span> class, which would be the most suitable solution. But for now, I think the workaround is enough for the plugin update.

I think I would leave the ticket open, as enhancement, to keep this in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants