Warn if typespec references filtered module #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusmuller
commented
Sep 7, 2023
| {{:type, AutolinkTest.Filtered, :type, 0}, :public} | ||
| ]) | ||
|
|
||
| # TODO: testing |
There was a problem hiding this comment.
I would like some guidance here, I was able to check the fix with a local project but I'm not sure what would be the best way to test this.
Also, maybe we should create a new test case for this, as it's a bit more complex than the other cases that are based only on autolink
|
💚 💙 💜 💛 ❤️ |
|
Are we going to add the test or it's not necessary for this? 👀 |
|
A PR with tests is welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the retriever to also return a list of filtered modules, and updates the code to warn if we find a typespec that references a type from a filtered module.
Closes #1744