Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar scroll regression introduced in #1760 (Firefox) #1773

Closed
zachallaun opened this issue Sep 14, 2023 · 4 comments · Fixed by #1776
Closed

Sidebar scroll regression introduced in #1760 (Firefox) #1773

zachallaun opened this issue Sep 14, 2023 · 4 comments · Fixed by #1776

Comments

@zachallaun
Copy link
Contributor

Hi friends! I noticed a regression in the sidebar behavior in Firefox today. Stepping back through commits and re-building, it looks like it was introduced in #1760.

image

@josevalim
Copy link
Member

I cannot reproduce this. What is your commit? Notice that we have a separate commit for updating the assets, is there any chance that you got a commit before the assets update? You can also try calling mix build. :)

@josevalim
Copy link
Member

I was able to reproduce it here: https://hexdocs.pm/elixir/main/Kernel.html

@angelikatyborska if you have the time, can you please take a look?

@angelikatyborska
Copy link
Contributor

Huh, I see! I did not test how the scrollbar looks like when it's overflowing vertically, and it does not look good. I'll try to fix it now.

Posting a screenshot for the record because the original one shows more problems than just the overflow:

Screenshot 2023-09-15 at 19-46-46 Kernel — Elixir v1 16 0-dev

@zachallaun
Copy link
Contributor Author

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants