From 150614cf3a99693be8526dc99a87d4ec483ff435 Mon Sep 17 00:00:00 2001
From: David Moulton <d.moulton@elifesciences.org>
Date: Wed, 18 Dec 2024 14:37:23 +0000
Subject: [PATCH] Remove premature test expansion to provide coverage

https://github.com/elifesciences/issues/issues/9034
---
 test/Serializer/ArticleVoRNormalizerTest.php | 38 ++++++++++----------
 1 file changed, 18 insertions(+), 20 deletions(-)

diff --git a/test/Serializer/ArticleVoRNormalizerTest.php b/test/Serializer/ArticleVoRNormalizerTest.php
index d4715fe7..6b5b5e9c 100644
--- a/test/Serializer/ArticleVoRNormalizerTest.php
+++ b/test/Serializer/ArticleVoRNormalizerTest.php
@@ -150,7 +150,7 @@ public function normalizeProvider() : array
                     ->withDecisionLetter(promise_for(new ArticleSection(new ArraySequence([new Paragraph('Article 09560 decision letter text')]), '10.7554/eLife.09560decisionLetter', 'decision-letter-id')))
                     ->withAuthorResponse(promise_for(new ArticleSection(new ArraySequence([new Paragraph('Article 09560 author response text')]), '10.7554/eLife.09560authorResponse', 'author-response-id')))
                     ->withElifeAssessmentArticleSection(promise_for(new ArticleSection(new ArraySequence([new Paragraph('Article 09560 elife assessment text')]), '10.7554/eLife.09560elifeAssessment', 'elife-assessment-id')))
-                    ->withElifeAssessment(new ElifeAssessment(['important'], ['solid']))
+//                    ->withElifeAssessment(new ElifeAssessment(['important'], ['solid']))
                     ->withRecommendationsForAuthors(promise_for(new ArticleSection(new ArraySequence([new Paragraph('Article 09560 recommendations for authors text')]), '10.7554/eLife.09560recommendationsForAuthors', 'recommendations-for-authors-id')))
                     ->withPublicReviews(new ArraySequence([new PublicReview('Public review 1', new ArraySequence([new Paragraph('Public review 1 content')]))]))
                     ->__invoke(),
@@ -449,8 +449,8 @@ public function normalizeProvider() : array
                         'scietyUri' => 'https://elife-assessment.com',
                         'doi' => '10.7554/eLife.09560elifeAssessment',
                         'id' => 'elife-assessment-id',
-                        'significance' => ['important'],
-                        'strength' => ['solid'],
+//                        'significance' => ['important'],
+//                        'strength' => ['solid'],
                     ],
                     'recommendationsForAuthors' =>  [
                         'title' => 'Recommendations for authors',
@@ -584,7 +584,7 @@ function ($test) {
                     ->withDecisionLetter(promise_for(new ArticleSection(new ArraySequence([new Paragraph('Article 09560 decision letter text')]), '10.7554/eLife.09560decisionLetter', 'decision-letter-id')))
                     ->withDecisionLetterDescription(new ArraySequence([new Paragraph('Article 09560 decision letter description')]))
                     ->withAuthorResponse(promise_for(new ArticleSection(new ArraySequence([new Paragraph('Article 09560 author response text')]), '10.7554/eLife.09560authorResponse', 'author-response-id')))
-                    ->withElifeAssessment(new ElifeAssessment(['landmark'], ['solid']))
+//                    ->withElifeAssessment(new ElifeAssessment(['landmark'], ['solid']))
                     ->withElifeAssessmentArticleSection(promise_for(new ArticleSection(new ArraySequence([new Paragraph('Article 09560 elife assessment text')]), '10.7554/eLife.09560elifeAssessment', 'elife-assessment-id')))
                     ->withElifeAssessmentTitle(promise_for('eLife assessment'))
                     ->withElifeAssessmentScietyUri(promise_for('https://elife-assessment-09560.com'))
@@ -655,20 +655,20 @@ function ($test) {
                     'curationLabels' => ['Landmark', 'Exceptional'],
                     'figuresPdf' => 'http://www.example.com/figures',
                     'impactStatement' => 'A new hominin species has been unearthed in the Dinaledi Chamber of the Rising Star cave system in the largest assemblage of a single species of hominins yet discovered in Africa.',
-                    'elifeAssessment' =>  [
-                        'title' => 'eLife assessment',
-                        'content' => [
-                            [
-                                'type' => 'paragraph',
-                                'text' => 'Article 09560 elife assessment text',
-                            ],
-                        ],
-                        'scietyUri' => 'https://elife-assessment-09560.com',
-                        'doi' => '10.7554/eLife.09560elifeAssessment',
-                        'id' => 'elife-assessment-id',
-                        'significance' => ['landmark'],
-                        'strength' => ['solid'],
-                    ]
+//                    'elifeAssessment' =>  [
+//                        'title' => 'eLife assessment',
+//                        'content' => [
+//                            [
+//                                'type' => 'paragraph',
+//                                'text' => 'Article 09560 elife assessment text',
+//                            ],
+//                        ],
+//                        'scietyUri' => 'https://elife-assessment-09560.com',
+//                        'doi' => '10.7554/eLife.09560elifeAssessment',
+//                        'id' => 'elife-assessment-id',
+//                        'significance' => ['landmark'],
+//                        'strength' => ['solid'],
+//                    ]
                 ],
                 function (ApiTestCase $test) {
                     $test->mockArticleCall('09560', true, true, 1);
@@ -731,8 +731,6 @@ function (ApiTestCase $test) {
                 },
             ],
         ];
-        unset($datasets['complete']);
-        unset($datasets['complete snippet']);
         return $datasets;
     }