Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.30 (was: Consider a new release?) #476

Closed
pombredanne opened this issue Jul 5, 2023 · 15 comments
Closed

Release 0.30 (was: Consider a new release?) #476

pombredanne opened this issue Jul 5, 2023 · 15 comments

Comments

@pombredanne
Copy link

It has been almost a year since 0.29 and there are great stuff in the latest head.... may be it is time to cut a release!
Thanks!

@eliben
Copy link
Owner

eliben commented Jul 6, 2023

I went over the commit log and I don't see lots of very major changes. Anything in particular there that you require?

@pombredanne
Copy link
Author

No major changes but bug fixes indeed! :]
Your call. No rush since there no no API changes that I can see.

@pombredanne
Copy link
Author

Some bugs are fixed for sure:
I have this in 0.29:

self = <elftools.dwarf.abbrevtable.AbbrevTable object at 0x7fc73cd9fbe0>, code = 7285

    def get_abbrev(self, code):
        """ Get the AbbrevDecl for a given code. Raise KeyError if no
            declaration for this code exists.
        """
>       return self._abbrev_map[code]
E       KeyError: 7285

venv/lib/python3.8/site-packages/elftools/dwarf/abbrevtable.py:36: KeyError

using this https://github.com/eliben/pyelftools/blob/master/test/testfiles_for_readelf/cuv5_x86-64_gcc.so.elf

but not with the latest head
(this is using dwarfdump for example)

@eliben eliben changed the title Consider a new release? Release 0.30 (was: Consider a new release?) Jul 10, 2023
@eliben
Copy link
Owner

eliben commented Jul 10, 2023

Renaming this issue. I'm OK with releasing the next version, but we'll need to see what is pending to get in.

@floppym
Copy link

floppym commented Jul 31, 2023

It would be great to have the LoongArch support from 2059475 in a release.

See https://bugs.gentoo.org/911484 .

@xen0n
Copy link
Contributor

xen0n commented Aug 2, 2023

Thanks for the followup for the bug, @floppym! I've since checked the existing logic and found they needed some fixes, and filed #483 for it. We probably want that included too if we're aiming for proper LoongArch support.

I'm applying that PR locally for testing and will post my results on the PR shortly after.

@eliben
Copy link
Owner

eliben commented Aug 23, 2023

@sevaa thoughts about making this release soon? I think we got almost all the pending stuff in.

@xen0n please act on the comments in #483 if you want this in 0.30; otherwise it will just make it into the next release - no big deal. FWIW I recommend people to use pyelftools hot and fresh off the master branch anyhow.

@sevaa
Copy link
Contributor

sevaa commented Aug 23, 2023

I'd prefer to get #483 in, and also I'd like to take a stab at bringing back the ranges test against the master head of binutils. I'll bump to a numbered release once there is one.

@sevaa
Copy link
Contributor

sevaa commented Aug 23, 2023

Sweet, another readelf bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30792

@sevaa
Copy link
Contributor

sevaa commented Sep 1, 2023

Quick update re: rangelists. There was no activity on that bug for a week, so I went into the sources. Remember the rant re: overlapping rangelists that I've left in pyelftools comments? Readelf has it both ways. For v4 sections, it goes by known rangelist offsets (aka "for utility"). For v5 sections, it goes by offset tables in rnglist-CU headers, aka "for fidelity", and does so incorrectly.

I'd take a stab at fixing this myself in readelf, but I really want the maintainers to confirm that inconsistency in approach is intentional or at least to be tolerated for now.

@sevaa
Copy link
Contributor

sevaa commented Sep 6, 2023

Aren't we done with the desired scope for 3.0? I still have on my plate two cases of shorted out autotests that I would prefer to address, but that's not functionality and can wait until after the release.

@eliben
Copy link
Owner

eliben commented Sep 6, 2023

I've tagged v0.30 and pushed it to PyPI.

@pombredanne and @sevaa please install the new version and let me know if you see any issues.

@sevaa
Copy link
Contributor

sevaa commented Sep 7, 2023

My tests pass.

Found some minor unrelated crud though, like some missing vendor attribute codes. Oh well.

@eliben
Copy link
Owner

eliben commented Sep 7, 2023

My tests pass.

Found some minor unrelated crud though, like some missing vendor attribute codes. Oh well.

Thanks for testing. Send a PR for the other stuff - I don't think that missing a release is a big deal. I recommend people to use the master version anyhow - with the testing we do on every commit it's usually more stable / less buggy than released versions.

@eliben eliben closed this as completed Sep 22, 2023
@pombredanne
Copy link
Author

@eliben Thank you ++. You rock 🎸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants