Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email notifications show broken images (due to authenticated media) #17832

Open
turt2live opened this issue Oct 15, 2024 · 0 comments
Open

Email notifications show broken images (due to authenticated media) #17832

turt2live opened this issue Oct 15, 2024 · 0 comments

Comments

@turt2live
Copy link
Member

Description

Reported on behalf of a conversation I saw: Email notifications use the legacy, unauthenticated, and deprecated URLs for avatars of rooms/senders, which don't work when authenticated media is in full force. This leads to the "broken image" placeholder in browsers/email clients.

The easiest fix is to remove the img elements entirely, as it's questionable to include them from a Trust & Safety perspective anyways (at least until there's better tooling available). Magic URLs like how bridges work may be desirable in the long term.

Steps to reproduce

  • receive an email notification

Homeserver

matrix.org

Synapse Version

whatever matrix.org runs

Installation Method

Other (please mention below)

Database

postgresql

Workers

Single process

Platform

matrix.org

Configuration

No response

Relevant log output

see matrix.org

Anything else that would be useful to know?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant