Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifier.wait_for_events(user_id) should notify when device_one_time_keys_count changes #17474

Open
MadLittleMods opened this issue Jul 23, 2024 · 1 comment · May be fixed by #17820
Open

notifier.wait_for_events(user_id) should notify when device_one_time_keys_count changes #17474

MadLittleMods opened this issue Jul 23, 2024 · 1 comment · May be fixed by #17820

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Jul 23, 2024

Spawning from a discussion on a Sliding Sync PR,


notifier.wait_for_events(user_id) is used in Sync v2 and Sliding Sync to to wait for something to happen before assembling a sync response.

It currently handles things like new events, account data, to-device messages, typing activity, etc but doesn't pick up when your device one-time-key (OTK) counts change which affects the device_one_time_keys_count/device_unused_fallback_key_types in the sync response and should be considered new activity.

Currently, if other devices exhaust your OTKs without other activity to notify your sync loop, you would never be notified to upload more.

@richvdh
Copy link
Member

richvdh commented Jul 26, 2024

This would also fix #17491, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants