-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caching strategy #24
Comments
we might be able to slightly improve the number by at the end of each token quota period fetching as many extra repos as possible, and pre fill the cache. That's not going to be of help though if we don't have any requests left anyway. |
Can we use the GraphQL api to update many repos at once? |
How about asking for the dev to add a webhook for the |
That's an interesting idea, @mathieudutour. More work on the part of the app developer, but could be worth it for scalability. |
Indeed, might be a little bit more work (even tho it takes literally 30s to add a webhook) but at the same time, the cache would be invalidated instantly (instead of potentially having to wait 15min) so it’s a win-win |
I like that! Seems like we could add it next, and then make this simpler by turning this into a GitHub app maybe? Also, with webhooks, the cache can expire never I think. |
If it’s a requirement to use this service, yes it could never expire. But we could also have a mix: if you want the cache to update directly when there is an update, then you need to add a webhook. But maybe we want to make it super simple to start and only have it as an optional (but strongly recommended) step |
We could also make a small FE for users to set up their repo's. GH API has a webhook endpoint so if we oAuth in we can set it all up for them: |
@MarshallOfSound very well analyzed:
The text was updated successfully, but these errors were encountered: