Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mac differential updater #8093

Closed
wants to merge 2 commits into from
Closed

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Mar 3, 2024

Reimplements: #7709

Copy link

changeset-bot bot commented Mar 3, 2024

🦋 Changeset detected

Latest commit: 0452b5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 0452b5c
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65e42c806ffe8d0008b1fb29
😎 Deploy Preview https://deploy-preview-8093--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…erential-download

# Conflicts:
#	packages/electron-updater/src/MacUpdater.ts
@beyondkmp
Copy link
Collaborator

This should have the same issue; the argument passed in should already be the temp file name.

https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/AppUpdater.ts#L685

@mmaietta
Copy link
Collaborator Author

mmaietta commented Mar 3, 2024

@beyondkmp could you please elaborate?
I was under the impression that await this.httpExecutor.download(zipFileInfo.url, destinationFile, downloadOptions) was never executed due to canDownloadDifferentially resolving the incorrect boolean value.

const canDifferentialDownload = () => {
if (!pathExistsSync(cachedFile)) {
log.info("Unable to locate previous update.zip for differential download (is this first install?), falling back to full download")
return false
}
return !downloadUpdateOptions.disableDifferentialDownload

@mmaietta mmaietta closed this Mar 4, 2024
@mmaietta mmaietta deleted the fix/differential-download branch March 4, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants