Skip to content

Commit

Permalink
revert: fix(mac): should normalize unicode strings from file system b…
Browse files Browse the repository at this point in the history
…efore used in string compare (#4841)

This reverts commit 37a17f2.
  • Loading branch information
jebibot committed Nov 29, 2023
1 parent 3973c66 commit 1e71eb1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .changeset/nine-rings-bow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"dmg-builder": patch
---

fix dmg build when productName or executableName contains Unicode
5 changes: 0 additions & 5 deletions packages/dmg-builder/vendor/mac_alias/alias.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import os.path
import stat
import sys
from unicodedata import normalize

if sys.platform == 'darwin':
from . import osx
Expand Down Expand Up @@ -390,10 +389,6 @@ def for_file(cls, path):
st = osx.statfs(path)
vol_path = st.f_mntonname

# File and folder names in HFS+ are normalized to a form similar to NFD.
# Must be normalized (NFD->NFC) before use to avoid unicode string comparison issues.
vol_path = normalize("NFC", vol_path.decode('utf-8')).encode('utf-8')

# Grab its attributes
attrs = [osx.ATTR_CMN_CRTIME,
osx.ATTR_VOL_NAME,
Expand Down

0 comments on commit 1e71eb1

Please sign in to comment.